[JENKINS-71687] Intellij IDEA Inspection causes Exception during Jenkins Job fix #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2023 15:35
…optional + add test
…optional + add test
…optional + add test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
uhafner
requested changes
Jul 26, 2023
| .setCategory(StringEscapeUtils.unescapeXml(getValue(problem))) | ||
| .setMessage(StringEscapeUtils.unescapeXml(getChildValue(element, "description"))) | ||
| .setModuleName(StringEscapeUtils.unescapeXml(getChildValue(element, "module"))) | ||
| .setSeverity(getPriority(problem.getAttribute("severity"))); | ||
| if(!getChildValue(element, "line").equals("-")){ |
There was a problem hiding this comment.
Extract the value into a local variable and reuse later
There was a problem hiding this comment.
Maybe it would be much simpler when you use IntegerParser.parseInt, then everything should work out of the box.
There was a problem hiding this comment.
Thanks for the feedback. As recommended I change the parser to IntegerParser.
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
=========================================
Coverage 92.89% 92.89%
Complexity 2322 2322
=========================================
Files 341 341
Lines 6450 6450
Branches 669 669
=========================================
Hits 5992 5992
Misses 262 262
Partials 196 196
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created regarding following issues:
https://issues.jenkins.io/browse/JENKINS-71687
also on
https://youtrack.jetbrains.com/issue/IDEA-325906/IDEA-Inspections-cause-Exception-during-Jenkins-Job
The Idea-Inspection of the new Idea-Versions doesn't return a line-number, which causes an Error in the parseInt function (For details see Issue JENKINS-71687) ->
So I made the issueBuilder.setLineStart(Integer.parseInt(getChildValue(element, "line"))); optional.
Testing done
I added a problem to the issue56235.xml, which gets tested in the IdeaInspectionParserTest.java.
Submitter checklist